Fix internal-secret test flakiness under slow environment#14024
Merged
sundb merged 1 commit intoredis:unstablefrom May 14, 2025
Merged
Fix internal-secret test flakiness under slow environment#14024sundb merged 1 commit intoredis:unstablefrom
sundb merged 1 commit intoredis:unstablefrom
Conversation
MeirShpilraien
approved these changes
May 14, 2025
sundb
added a commit
that referenced
this pull request
May 21, 2025
…4055) This PR is a reference from valkey-io/valkey#1535 In the process of handling the failure(#14024) of ARM64 CI with TLS, found in a slow environment, the nodes might frequently disconnect and trigger this assertion. --------- Co-authored-by: Binbin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the original test, we start a cluster with 20 instances(10 masters + 10 replicas), which leads to frequent disconnections of instances in a slow environment, resulting in an inability to achieve consistency.
This test reduced the number of instances from 20 to 6.