Fix timing issue in lazyfree test#13926
Merged
sundb merged 3 commits intoredis:unstablefrom Apr 13, 2025
Merged
Conversation
tezc
reviewed
Apr 9, 2025
tezc
approved these changes
Apr 9, 2025
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
This test was introduced by redis#13853 We determine if the client is in blocked status, but if async flushdb is completed before checking the blocked status, the test will fail. So modify the test to only determine if `lazyfree_pending_objects` is correct to ensure that flushdb is async, that is, the client must be blocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was introduced by #13853
We determine if the client is in blocked status, but if async flushdb is completed before checking the blocked status, the test will fail.
So modify the test to only determine if
lazyfree_pending_objectsis correct to ensure that flushdb is async, that is, the client must be blocked.Failed CI: https://github.com/redis/redis/actions/runs/14297983338/job/40067661367