Do not call _dictClear()'s callback for the first 65k items #13674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make sense, LGTM |
sundb
approved these changes
Dec 3, 2024
YaacovHazan
pushed a commit
that referenced
this pull request
Jan 14, 2025
In #13495, we introduced a feature to reply -LOADING while flushing a large db on a replica. While `_dictClear()` is in progress, it calls a callback for every 65k items and we yield back to eventloop to reply -LOADING. This change has made some tests unstable as those tests don't expect new -LOADING reply. One observation, inside `_dictClear()`, we call the callback even if db has a few keys. Most tests run with small amount of keys. So, each replication and cluster test has to handle potential -LOADING reply now. This PR changes this behavior, skips calling callback when `i=0` to stabilize replication tests. Callback will be called after the first 65k items. Most tests use less than 65k keys and they won't get -LOADING reply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #13495, we introduced a feature to reply -LOADING while flushing a large db on a replica.
While
_dictClear()is in progress, it calls a callback for every 65k items and we yield back to eventloop to reply -LOADING.This change has made some tests unstable as those tests don't expect new -LOADING reply.
One observation, inside
_dictClear(), we call the callback even if db has a few keys. Most tests run with small amount of keys. So, each replication and cluster test has to handle potential -LOADING reply now.This PR changes this behavior, skips calling callback when
i=0to stabilize replication tests.Callback will be called after the first 65k items. Most tests use less than 65k keys and they won't get -LOADING reply.