Deprecate utils/redis-copy.rb in favor of redis-copy gem#1365
Merged
antirez merged 1 commit intoredis:unstablefrom Nov 6, 2013
Merged
Deprecate utils/redis-copy.rb in favor of redis-copy gem#1365antirez merged 1 commit intoredis:unstablefrom
antirez merged 1 commit intoredis:unstablefrom
Conversation
antirez
added a commit
that referenced
this pull request
Nov 6, 2013
Deprecate utils/redis-copy.rb in favor of redis-copy gem
Contributor
|
Hello, I merged since I'm sure your version is better, however now that we are in 2.8 land, we have both SCAN and MIGRATE (or DUMP + RESTORE if we want more control) to implement the same command in a more reliable and probably two order of magnitude fasters! But for 2.6, the old approach is still needed. Thanks for your work. |
Contributor
Author
|
@antirez yep! The goal of the gem is to be an abstraction across the migration features, using the best features possible and falling back gracefully to slower/less-efficient methods. |
Contributor
|
Cool, thanks! |
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Aug 29, 2016
…-in-2.6 2.6 branch backport of redis#1365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When needing to do a semi-live redis copy recently from db1 on one box to db3 on another, I stumbled across the
utils/redis-copy.rbscript and ended up working it into a well-tested gem that was able to handle all of the datatypes and different db numbers.The gem has since evolved to support
DUMP/RESTORE(iff supported by both source and destination redis processes), optional verification, and even will supportSCANfor key-emitting in the near future. As such, I think it is a good time to deprecate theutils/redis-copy.rb.