Increment kvstore's non_empty_dicts only on first insert #13528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s positive Co-authored-by: oranagra <[email protected]>
sundb
changed the title
oranagra
previously approved these changes
Sep 10, 2024
oranagra
approved these changes
Sep 10, 2024
YaacovHazan
pushed a commit
that referenced
this pull request
Nov 4, 2024
Found by @oranagra Currently, when the size of dict becomes 1, we do not check whether `delta` is positive or negative. As a result, `non_empty_dicts` is still incremented when the size of dict changes from 2 to 1. We should only increment `non_empty_dicts` when `delta` is positive, as this indicates the first time an element is inserted into the dict. --------- Co-authored-by: oranagra <[email protected]>
YaacovHazan
pushed a commit
that referenced
this pull request
Jan 6, 2025
Found by @oranagra Currently, when the size of dict becomes 1, we do not check whether `delta` is positive or negative. As a result, `non_empty_dicts` is still incremented when the size of dict changes from 2 to 1. We should only increment `non_empty_dicts` when `delta` is positive, as this indicates the first time an element is inserted into the dict. --------- Co-authored-by: oranagra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by @oranagra
Currently, when the size of dict becomes 1, we do not check whether
deltais positive or negative.As a result,
non_empty_dictsis still incremented when the size of dict changes from 2 to 1.We should only increment
non_empty_dictswhendeltais positive, as this indicates the first time an element is inserted into the dict.