Add the option to build Redis with modules #13524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamiBs
reviewed
Sep 8, 2024
modules/redisearch/Makefile
Outdated
|
|
||
| include ../common.mk | ||
|
|
||
| get_source: $(BOOST_DIR)/.downloaded |
YaacovHazan
force-pushed
the
add-modules-build
branch
from
5ee951e to
ac2cbbd
Compare
adamiBs
reviewed
Sep 8, 2024
modules/Makefile
Outdated
| @@ -0,0 +1,72 @@ | |||
|
|
|||
| SUBDIRS = rejson redistimeseries redisbloom redisearch | |||
There was a problem hiding this comment.
Wrong folder name for ReJSON
There was a problem hiding this comment.
I suggest replacing the name of the directory to rejson instead of changing it here to redisjson
YaacovHazan
force-pushed
the
add-modules-build
branch
from
f7a3a89 to
3ae03e8
Compare
A new BUILD_WITH_MODULES flag was added to the Makefile to control building the module directory. The new module directory includes a general Makefile that iterates over each module, fetch a specific version, and build it.
YaacovHazan
force-pushed
the
add-modules-build
branch
from
3ae03e8 to
87e8d56
Compare
adamiBs
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new BUILD_WITH_MODULES flag was added to the Makefile to control
building the module directory.
The new module directory includes a general Makefile that iterates
over each module, fetch a specific version, and build it.