Fix flaky replication tests #13518
Merged
Fix flaky replication tests #13518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tezc
commented
Sep 7, 2024
| # Replica may start a full sync after restart, trying in a loop to avoid | ||
| # -LOADING reply in that case. | ||
| wait_for_condition 1000 50 { | ||
| [catch {set replica_dbsize_3 [R $replica_id dbsize]} e] == 0 |
There was a problem hiding this comment.
@sundb I got a feeling that this test wants to check dbsize even before replication (just after restart). So, I added catch + loop, we'll try in a loop. Most of the time, successful execution will be before replication. On a slow CI, it might be after replication. In both cases, it should give us the correct result.
sundb
approved these changes
Sep 8, 2024
|
seems like CI has stablized now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13495 introduced a change to reply -LOADING while flushing existing db on a replica.
Some of our tests are sensitive to this change and do no expect -LOADING reply.
Fixing a couple of tests that fail time to time.