Skip to content

Update old links for modules-api-ref.md#13479

Merged
oranagra merged 2 commits intoredis:unstablefrom
dwdougherty:dwdougherty-link-updates
Nov 4, 2024
Merged

Update old links for modules-api-ref.md#13479
oranagra merged 2 commits intoredis:unstablefrom
dwdougherty:dwdougherty-link-updates

Conversation

@dwdougherty
Copy link
Copy Markdown
Contributor

This PR replaces old .../topics/... links with current links, specifically for the modules-api-ref.md file and the new automation that Paolo Lazzari is working on. A few of the topics links have redirects, but some don't. Best to use updated links.

@dwdougherty
Copy link
Copy Markdown
Contributor Author

This PR needs to be merged, as it affects module API doc updates.

@dwdougherty
Copy link
Copy Markdown
Contributor Author

@oranagra and @yossigo Would one of you approve and merge this PR? It contains changes to several links that appear in the modules API docs when the utils/generate-module-api-doc.rb is run. This is needed by the automation @paoloredis put in place to automatically update commands.json content when a new GA release is tagged.

Thank you!

Comment thread deps/hiredis/async.c
/* Match reply with the expected format of a pushed message.
* The type and number of elements (3 to 4) are specified at:
* https://redis.io/topics/pubsub#format-of-pushed-messages */
* https://redis.io/docs/latest/develop/interact/pubsub/#format-of-pushed-messages */
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in theory, this should be made in the upstream hiredis repo and pulled form there.
but i don't think it's an issue to change it here first / too

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Thanks, @oranagra . I've opened a PR there as well.

@oranagra oranagra merged commit 9906daf into redis:unstable Nov 4, 2024
@dwdougherty dwdougherty deleted the dwdougherty-link-updates branch November 4, 2024 16:36
@sundb sundb removed this from Redis 8.2 Aug 15, 2025
@sundb sundb added this to Redis 8.0 Aug 15, 2025
@sundb sundb moved this from Todo to Done in Redis 8.0 Aug 15, 2025
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
This PR replaces old .../topics/... links with current links,
specifically for the modules-api-ref.md file and the new automation that
Paolo Lazzari is working on. A few of the topics links have redirects,
but some don't. Best to use updated links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants