Fix error message for XREAD command with wrong parameter#13474
Merged
sundb merged 1 commit intoredis:unstablefrom Aug 14, 2024
Merged
Fix error message for XREAD command with wrong parameter#13474sundb merged 1 commit intoredis:unstablefrom
sundb merged 1 commit intoredis:unstablefrom
Conversation
sundb
commented
Aug 14, 2024
| streams_count = (c->argc-streams_arg); | ||
| if ((streams_count % 2) != 0) { | ||
| char symbol = xreadgroup ? '>' : '$'; | ||
| const char *symbol = xreadgroup ? "ID or '>'" : "ID, '+', or '$'"; |
Collaborator
Author
There was a problem hiding this comment.
i made the ID repeat here because it's easier to maintain and more readable.
LiorKogan
approved these changes
Aug 14, 2024
oranagra
approved these changes
Aug 14, 2024
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
could be an indication that the error message is too specific or verbose. 🤷
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
Fixed a missing from redis#13117. When the number of streams is incorrect, the error message for `XREAD` needs to include the '+' symbol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a missing from #13117.
When the number of streams is incorrect, the error message for
XREADneeds to include the '+' symbol.