Merged
Conversation
fix spaces Co-authored-by: debing.sun <[email protected]>
fix spaces Co-authored-by: debing.sun <[email protected]>
fix log Co-authored-by: debing.sun <[email protected]>
oranagra
previously approved these changes
Jul 8, 2024
oranagra
added
the
release-notes
sundb
commented
Jul 9, 2024
Comment on lines
-1157
to
-1158
| catch { | ||
| set ldd [exec ldd src/redis-server] |
Collaborator
Author
There was a problem hiding this comment.
In tcl, return in catch is used to exit the block of catch not the block of proc, it will leave catch and continue to execute 'return 0'.
proc test {} {
catch {
puts "a"
return
puts "b"
}
puts "c"
}
testoutput:
a
c
oranagra
approved these changes
Jul 9, 2024
sundb
added a commit
to sundb/redis
that referenced
this pull request
Jul 10, 2024
This reverts commit 69b480c.
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
This PR is based on the commits from PR redis#11747. In the event of an assertion failure, hide command arguments from the operator. In some cases, private client information can be voluntarily exposed when a redis instance crashes due to an assertion failure. This commit prevent וnintentional client info exposure. Operators can still access the hidden data, but they must actively request it. Any of the client info commands remains the unchanged. ### Config Add a new config `hide-user-data-from-log` to turn this feature on and off, default off. --------- Co-authored-by: naglera <[email protected]> Co-authored-by: naglera <[email protected]>
Merged
sundb
pushed a commit
that referenced
this pull request
Jan 4, 2026
This PR continues the work from [#13400](#13400), following the discussion in [#11747](#11747 (comment)), to further ensure sensitive user data is not exposed in logs when hide_user_data_from_log is enabled. - Introduce redactLogCstr() helper for safe, centralized log redaction. - Update ACL and networking log messages to use redacted values where appropriate. - Prevent leaking raw query buffer contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on the commits from PR #11747.
In the event of an assertion failure, hide command arguments from the operator.
In some cases, private client information can be voluntarily exposed when a redis instance crashes due to an assertion failure.
This commit prevent וnintentional client info exposure.
Operators can still access the hidden data, but they must actively request it.
Any of the client info commands remains the unchanged.
Config
Add a new config
hide-user-data-from-logto turn this feature on and off, default off.Co-authored-by: naglera [email protected]