HFE - count in command must match actual number of fields#13369
Merged
moticless merged 5 commits intoredis:unstablefrom Jun 26, 2024
Merged
HFE - count in command must match actual number of fields#13369moticless merged 5 commits intoredis:unstablefrom
moticless merged 5 commits intoredis:unstablefrom
Conversation
tezc
previously approved these changes
Jun 26, 2024
moticless
changed the title
sundb
reviewed
Jun 26, 2024
sundb
approved these changes
Jun 26, 2024
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
There was wrong preliminary assumption that we can optionally provide vector of arguments more than count. This is error-prone approach that leaded to actual error in that case. This PR enforce that vector of argument match count. Also fixed flaky HRANDFIELD test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was wrong preliminary assumption that we can optionally provide vector of arguments more than count.
This is error-prone approach that leaded to actual error in that case. This PR enforce that vector of argument match count.
Also fixed flaky HRANDFIELD test.