Reserve 2 bits out of EB_EXPIRE_TIME_MAX for possible future use#13331
Merged
moticless merged 2 commits intoredis:unstablefrom Jun 10, 2024
Merged
Reserve 2 bits out of EB_EXPIRE_TIME_MAX for possible future use#13331moticless merged 2 commits intoredis:unstablefrom
moticless merged 2 commits intoredis:unstablefrom
Conversation
Collaborator
Author
|
@tezc, rdb.c relies on |
Collaborator
|
Yes, I saw it later. |
tezc
approved these changes
Jun 10, 2024
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
…is#13331) Reserve 2 bits out of hash-field expiration time (`EB_EXPIRE_TIME_MAX`) for possible future lightweight indexing/categorizing of fields. It can be achieved by hacking HFE as follows: ``` HPEXPIREAT key [ 2^47 + USER_INDEX ] FIELDS numfields field [field …] ``` Redis will also need to expose kind of `HEXPIRESCAN` and `HEXPIRECOUNT` for this idea. Yet to be better defined. `HFE_MAX_ABS_TIME_MSEC` constraint must be enforced only at API level. Internally, the expiration time can be up to `EB_EXPIRE_TIME_MAX` for future readiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserve 2 bits out of hash-field expiration time (
#define HFE_MAX_ABS_TIME_MSEC (EB_EXPIRE_TIME_MAX >> 2)) for possible future lightweight indexing/categorizing of fields. It can be achieved by hacking HFE as follows:Redis will also need to expose kind of
HEXPIRESCANandHEXPIRECOUNTfor this idea. Yet to be better defined.HFE_MAX_ABS_TIME_MSECconstraint must be enforced only at API level. Internally, the expiration time can be up toEB_EXPIRE_TIME_MAXfor future readiness.