Skip to content

Delete hsetf and hgetf#13291

Merged
tezc merged 3 commits intoredis:hash-field-expiry-integfrom
tezc:del-hsetf
May 26, 2024
Merged

Delete hsetf and hgetf#13291
tezc merged 3 commits intoredis:hash-field-expiry-integfrom
tezc:del-hsetf

Conversation

@tezc
Copy link
Copy Markdown
Collaborator

@tezc tezc commented May 24, 2024

Based on the latest decision:

  • Delete hsetf and hgetf commands
  • If key does not exist, HEXPIRE, HPEXPIRE, HEXPIREAT, HPEXPIREAT, HPERSIST, HEXPIRETIME, HPEXPIRETIME, HTTL, HPTTL will return empty array instead of nil

@tezc tezc requested review from moticless, ronen-kalish and sundb May 24, 2024 09:44
sundb
sundb previously approved these changes May 24, 2024

test {DUMP / RESTORE are able to serialize / unserialize a hash with TTL 0 for all fields} {
r config set sanitize-dump-payload yes
r del myhash
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing.

@tezc tezc mentioned this pull request May 26, 2024
@tezc
Copy link
Copy Markdown
Collaborator Author

tezc commented May 26, 2024

@moticless See these changes as it will impact your work. Feel free to merge the PR.

@tezc
Copy link
Copy Markdown
Collaborator Author

tezc commented May 26, 2024

@sundb @moticless could you approve please?

moticless
moticless previously approved these changes May 26, 2024
Comment thread tests/unit/type/hash-field-expire.tcl Outdated
@tezc tezc merged commit 2f34f6f into redis:hash-field-expiry-integ May 26, 2024
@tezc tezc mentioned this pull request May 27, 2024
tezc added a commit that referenced this pull request May 27, 2024
In #13291, we've changed that hfe
commands to return empty array if the key does not exist.
Forgot to update json schemas.
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
Changes:
- Delete hsetf and hgetf commands
- Hfe commands will return empty array instead of nil.
---------

Co-authored-by: Moti Cohen <[email protected]>
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
In redis#13291, we've changed that hfe
commands to return empty array if the key does not exist.
Forgot to update json schemas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants