Fix ebuckets stop indication during ebExpire()#13287
Merged
moticless merged 1 commit intoredis:hash-field-expiry-integfrom May 23, 2024
Merged
Fix ebuckets stop indication during ebExpire()#13287moticless merged 1 commit intoredis:hash-field-expiry-integfrom
moticless merged 1 commit intoredis:hash-field-expiry-integfrom
Conversation
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
on active-expire of buckets, at function `ebExpire()` -> `ebSegExpire()`, if callback `onExpireItem()` indicated to stop, Yet iterator (iter) was wrongly already got updated to point to next item. In turn the segment will be updated without current item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on active-expire of buckets, at function
ebExpire()->ebSegExpire(), if callbackonExpireItem()indicated to stop, Yet iterator (iter) was wrongly already got updated to point to next item. In turn the segment will be updated without current item.