Fix commands H*EXPIRE* and H*TTL to include constant FIELDS #13270
Merged
moticless merged 9 commits intoredis:hash-field-expiry-integfrom May 16, 2024
Merged
Fix commands H*EXPIRE* and H*TTL to include constant FIELDS #13270moticless merged 9 commits intoredis:hash-field-expiry-integfrom
moticless merged 9 commits intoredis:hash-field-expiry-integfrom
Conversation
tezc
reviewed
May 15, 2024
tezc
previously approved these changes
May 15, 2024
Contributor
|
Apologies if I'm intruding here, but I don't see HPEXPIREAT in the list of changes. Maybe it's in another PR? Also, from the PRD, it looks like HPERSIST should also have the FIELDS argument. |
LiorKogan
reviewed
May 16, 2024
Collaborator
Author
|
@dwdougherty, I forgot to modify hpersist.json. Thanks! |
LiorKogan
reviewed
May 16, 2024
LiorKogan
reviewed
May 16, 2024
LiorKogan
approved these changes
May 16, 2024
tezc
added a commit
that referenced
this pull request
May 18, 2024
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
…13270) The same goes to: HPEXPIRE, HEXPIREAT, HPEXPIREAT, HEXPIRETIME, HPEXPIRETIME, HPTTL, HTTL, HPERSIST
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
…#13277) FIELDS keyword was added as part of [redis#13270](redis#13270). It was missing in [redis#13243](redis#13243)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
HEXPIRE myhash 1 NX 1 field1will be:
HEXPIRE myhash 1 NX FIELDS 1 field1The same goes to: HPEXPIRE, HEXPIREAT, HPEXPIREAT, HEXPIRETIME, HPEXPIRETIME, HPTTL, HTTL, HPERSIST