Skip to content

Add notification support for HFE #13237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sundb merged 8 commits into from
May 9, 2024
+26 −8
Merged

Add notification support for HFE #13237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6e75c3f
Add notifications for HFE
sundb Apr 30, 2024
14dd84f
Merge h*expire* command's notification as hexpire
sundb May 8, 2024
4c4bf88
Merge branch 'hash-field-expiry-integ' into hfe-notification
sundb May 8, 2024
fd729ec
Revert commands.def
sundb May 8, 2024
79a1ca8
Add comment
sundb May 8, 2024
e0e7989
Merge branch 'hash-field-expiry-integ' into hfe-notification
sundb May 9, 2024
005abdd
Test HFE notification with listpackex encoding
sundb May 9, 2024
f85eba4
Update the command_flags and flags in hpersist.json
sundb May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge h*expire* command's notification as hexpire
  • Loading branch information
@sundb
sundb committed May 8, 2024
commit 14dd84f671612ab3f1e8fc2427450be67d3da7e5
2 changes: 1 addition & 1 deletion src/t_hash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ void hashTypeSetExDone(HashTypeSetEx *ex) {
if (ex->c) {
server.dirty += ex->fieldDeleted + ex->fieldUpdated;
signalModifiedKey(ex->c, ex->db, ex->key);
notifyKeyspaceEvent(NOTIFY_HASH, ex->cmd, ex->key, ex->db->id);
notifyKeyspaceEvent(NOTIFY_HASH, "hexpire", ex->key, ex->db->id);
}
if (ex->fieldDeleted && hashTypeLength(ex->hashObj, 0) == 0) {
dbDelete(ex->db,ex->key);
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/pubsub.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,8 @@ start_server {tags {"pubsub network"}} {
assert_equal "pmessage * __keyspace@${db}__:myhash hset" [$rd1 read]
assert_equal "pmessage * __keyspace@${db}__:myhash hincrby" [$rd1 read]
assert_equal "pmessage * __keyspace@${db}__:myhash hexpire" [$rd1 read]
assert_equal "pmessage * __keyspace@${db}__:myhash hexpireat" [$rd1 read]
assert_equal "pmessage * __keyspace@${db}__:myhash hpexpire" [$rd1 read]
assert_equal "pmessage * __keyspace@${db}__:myhash hexpire" [$rd1 read]
assert_equal "pmessage * __keyspace@${db}__:myhash hexpire" [$rd1 read]
assert_equal "pmessage * __keyspace@${db}__:myhash hpersist" [$rd1 read]
$rd1 close
}
Expand Down