Skip to content

Add notification support for HFE#13237

Merged
sundb merged 8 commits intoredis:hash-field-expiry-integfrom
sundb:hfe-notification
May 9, 2024
Merged

Add notification support for HFE#13237
sundb merged 8 commits intoredis:hash-field-expiry-integfrom
sundb:hfe-notification

Conversation

@sundb
Copy link
Copy Markdown
Collaborator

@sundb sundb commented Apr 30, 2024 •
edited
Loading

  1. Add hpersist notification for hpersist command.
  2. Add pexpire notification for hexpire, hexpireat and hpexpire.

@sundb sundb requested a review from moticless April 30, 2024 07:52
moticless
moticless previously approved these changes Apr 30, 2024
View reviewed changes
@sundb
Copy link
Copy Markdown
Collaborator Author

sundb commented May 3, 2024

we will continue this PR after #13209.

@sundb
Copy link
Copy Markdown
Collaborator Author

sundb commented May 8, 2024

@moticless please have a look commit 14dd84f (#13237).
now we only add two notification, hexpire and hpersist.

@sundb sundb requested a review from moticless May 9, 2024 06:28
@moticless
Copy link
Copy Markdown
Collaborator

moticless commented May 9, 2024

@sundb, since you already touching the area of hpersist, I see now that i didn't wrote correct value for command_flags and flags in hpersist.json. Do you mind to correct it as part of this PR?

@sundb
Copy link
Copy Markdown
Collaborator Author

sundb commented May 9, 2024

@moticless OK.

moticless
moticless reviewed May 9, 2024
View reviewed changes
Comment thread tests/unit/pubsub.tcl Outdated
@sundb sundb requested a review from moticless May 9, 2024 09:23
@sundb
Copy link
Copy Markdown
Collaborator Author

sundb commented May 9, 2024

@moticless Updated the hpersist schema.

@sundb sundb merged commit 7010f41 into redis:hash-field-expiry-integ May 9, 2024
@sundb sundb deleted the hfe-notification branch May 9, 2024 14:23
@sundb sundb added the state:needs-doc-pr requires a PR to redis-doc repository label May 16, 2024
@LiorKogan LiorKogan mentioned this pull request May 16, 2024
Merged
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
@sundb
Add notification support for HFE (redis#13237)
ea2625e 
1. Add `hpersist` notification for `hpersist` command.
2. Add `pexpire` notification for `hexpire`, `hexpireat` and `hpexpire`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moticless moticless moticless approved these changes

Assignees

No one assigned

Labels

state:needs-doc-pr requires a PR to redis-doc repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sundb @moticless