Support HSET+expire in one command, at infra level#13230
Merged
moticless merged 5 commits intoredis:hash-field-expiry-integfrom Apr 25, 2024
Merged
Support HSET+expire in one command, at infra level#13230moticless merged 5 commits intoredis:hash-field-expiry-integfrom
moticless merged 5 commits intoredis:hash-field-expiry-integfrom
Conversation
tezc
approved these changes
Apr 25, 2024
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
Unify infra of `HSETF`, `HEXPIRE`, `HSET` and provide API for RDB load as well. Whereas setting plain fields is rather straightforward, setting expiration time to fields might be time-consuming and complex since each update of expiration time, not only updates `ebuckets` of corresponding hash, but also might update `ebuckets` of global HFE DS. It is required to opt sequence of field updates with expirartion for a given hash, such that only once done, the global HFE DS will get updated. To do so, follow the scheme: 1. Call `hashTypeSetExInit()` to initialize the HashTypeSetEx struct. 2. Call `hashTypeSetEx()` one time or more, for each field/expiration update. 3. Call `hashTypeSetExDone()` for notification and update of global HFE. If expiration is not required, then avoid this API and use instead hashTypeSet().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify infra of
HSETF,HEXPIRE,HSETand provide API for RDB load as well.Whereas setting plain fields is rather straightforward, setting expiration
time to fields might be time-consuming and complex since each update of
expiration time, not only updates
ebucketsof corresponding hash, but alsomight update
ebucketsof global HFE DS. It is required to opt sequence offield updates with expirartion for a given hash, such that only once done,
the global HFE DS will get updated.
To do so, follow the scheme:
hashTypeSetExInit()to initialize the HashTypeSetEx struct.hashTypeSetEx()one time or more, for each field/expiration update.hashTypeSetExDone()for notification and update of global HFE.If expiration is not required, then avoid this API and use instead hashTypeSet()