Skip to content

Check user's oom_score_adj write permission for oom-score-adj test#13111

Merged
oranagra merged 3 commits intoredis:unstablefrom
sundb:oom_score_permission
Mar 5, 2024
Merged

Check user's oom_score_adj write permission for oom-score-adj test#13111
oranagra merged 3 commits intoredis:unstablefrom
sundb:oom_score_permission

Conversation

@sundb
Copy link
Collaborator

@sundb sundb commented Mar 5, 2024

CONFIG SET oom-score-adj handles configuration failures test failed in some CI jobs today.
Failed CI: https://github.com/redis/redis/actions/runs/8152519326

Not sure why the github action's docker image perssions have changed, but the issue is similar to #12887,
where we can't assume the range of oom_score_adj that a user can change.

Solution:

Modify the way of determining whether the current user has no privileges or not,
instead of relying on whether the user id is 0 or not.

@sundb sundb requested review from oranagra and yossigo March 5, 2024 12:31
@sundb
Copy link
Collaborator Author

sundb commented Mar 5, 2024

@oranagra oranagra merged commit 9738ba9 into redis:unstable Mar 5, 2024
@sundb sundb deleted the oom_score_permission branch March 5, 2024 12:43
YaacovHazan pushed a commit to YaacovHazan/redis that referenced this pull request May 16, 2024
…edis#13111)

`CONFIG SET oom-score-adj handles configuration failures` test failed in
some CI jobs today.
Failed CI: https://github.com/redis/redis/actions/runs/8152519326

Not sure why the github action's docker image perssions have changed,
but the issue is similar to redis#12887,
where we can't assume the range of oom_score_adj that a user can change.

## Solution:
Modify the way of determining whether the current user has no privileges
or not,
instead of relying on whether the user id is 0 or not.

(cherry picked from commit 9738ba9)
YaacovHazan pushed a commit that referenced this pull request May 19, 2024
…13111)

`CONFIG SET oom-score-adj handles configuration failures` test failed in
some CI jobs today.
Failed CI: https://github.com/redis/redis/actions/runs/8152519326

Not sure why the github action's docker image perssions have changed,
but the issue is similar to #12887,
where we can't assume the range of oom_score_adj that a user can change.

## Solution:
Modify the way of determining whether the current user has no privileges
or not,
instead of relying on whether the user id is 0 or not.

(cherry picked from commit 9738ba9)
@oranagra oranagra mentioned this pull request Oct 5, 2024
@sundb sundb mentioned this pull request Jan 6, 2025
sundb added a commit to sundb/redis that referenced this pull request Jan 11, 2025
…edis#13111)

`CONFIG SET oom-score-adj handles configuration failures` test failed in
some CI jobs today.
Failed CI: https://github.com/redis/redis/actions/runs/8152519326

Not sure why the github action's docker image perssions have changed,
but the issue is similar to redis#12887,
where we can't assume the range of oom_score_adj that a user can change.

## Solution:
Modify the way of determining whether the current user has no privileges
or not,
instead of relying on whether the user id is 0 or not.
sundb added a commit to sundb/redis that referenced this pull request Jan 13, 2025
…edis#13111)

`CONFIG SET oom-score-adj handles configuration failures` test failed in
some CI jobs today.
Failed CI: https://github.com/redis/redis/actions/runs/8152519326

Not sure why the github action's docker image perssions have changed,
but the issue is similar to redis#12887,
where we can't assume the range of oom_score_adj that a user can change.

## Solution:
Modify the way of determining whether the current user has no privileges
or not,
instead of relying on whether the user id is 0 or not.
sundb added a commit to sundb/redis that referenced this pull request Jan 14, 2025
…edis#13111)

`CONFIG SET oom-score-adj handles configuration failures` test failed in
some CI jobs today.
Failed CI: https://github.com/redis/redis/actions/runs/8152519326

Not sure why the github action's docker image perssions have changed,
but the issue is similar to redis#12887,
where we can't assume the range of oom_score_adj that a user can change.

## Solution:
Modify the way of determining whether the current user has no privileges
or not,
instead of relying on whether the user id is 0 or not.
sundb added a commit that referenced this pull request Jan 15, 2025
…13111)

`CONFIG SET oom-score-adj handles configuration failures` test failed in
some CI jobs today.
Failed CI: https://github.com/redis/redis/actions/runs/8152519326

Not sure why the github action's docker image perssions have changed,
but the issue is similar to #12887,
where we can't assume the range of oom_score_adj that a user can change.

## Solution:
Modify the way of determining whether the current user has no privileges
or not,
instead of relying on whether the user id is 0 or not.
@YaacovHazan YaacovHazan moved this from To Do to In progress in Redis 6.2 Backport Apr 22, 2025
@YaacovHazan YaacovHazan moved this from In progress to Done in Redis 6.2 Backport Apr 29, 2025
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
…edis#13111)

`CONFIG SET oom-score-adj handles configuration failures` test failed in
some CI jobs today.
Failed CI: https://github.com/redis/redis/actions/runs/8152519326

Not sure why the github action's docker image perssions have changed,
but the issue is similar to redis#12887,
where we can't assume the range of oom_score_adj that a user can change.

## Solution:
Modify the way of determining whether the current user has no privileges
or not,
instead of relying on whether the user id is 0 or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants