Check whether the client is NULL in luaCreateFunction#12829
Merged
oranagra merged 2 commits intoredis:unstablefrom Dec 4, 2023
Merged
Check whether the client is NULL in luaCreateFunction#12829oranagra merged 2 commits intoredis:unstablefrom
oranagra merged 2 commits intoredis:unstablefrom
Conversation
It was first added to load lua from RDB, see 28dfdca. After redis#9812, we no longer save lua in RDB. luaCreateFunction will only be called in script load and eval*, both of which are available in the client. Remove the dead code and comments to avoid misunderstandings.
enjoy-binbin
commented
Dec 4, 2023
oranagra
reviewed
Dec 4, 2023
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
i'd rather keep it.
it could be that that some day we'll still want to load scripts from somewhere that's not a client.
enjoy-binbin
changed the title
Contributor
Author
|
ok, fair enough, this fix is in dead code. |
oranagra
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was first added to load lua from RDB, see 28dfdca. After #9812,
we no longer save lua in RDB. luaCreateFunction will only be called
in script load and eval*, both of which are available in the client.
It could be that that some day we'll still want to load scripts from
somewhere that's not a client. This fix is in dead code.