Optimize KEYS when pattern includes hashtag and implies a single slot.#12754
Merged
oranagra merged 5 commits intoredis:unstablefrom Dec 5, 2023
Merged
Optimize KEYS when pattern includes hashtag and implies a single slot.#12754oranagra merged 5 commits intoredis:unstablefrom
oranagra merged 5 commits intoredis:unstablefrom
Conversation
CharlesChen888
changed the title
zuiderkwast
reviewed
Nov 13, 2023
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
If we have this for SCAN, then I agree it makes sense for KEYS too.
CharlesChen888
force-pushed
the
keys-hashtag
branch
from
d1e9ee8 to
7375ed0
Compare
soloestoy
added
the
release-notes
oranagra
approved these changes
Nov 16, 2023
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
conceptually approving this.
core-team needs to decide if / how this should be documented.
Member
|
@redis/core-team as discussed in the meeting, please approve this one. |
Contributor
Author
|
@oranagra @zuiderkwast please review again |
CharlesChen888
force-pushed
the
keys-hashtag
branch
from
7375ed0 to
93f2794
Compare
soloestoy
approved these changes
Nov 29, 2023
madolson
approved these changes
Dec 5, 2023
zuiderkwast
approved these changes
Dec 5, 2023
soloestoy
pushed a commit
that referenced
this pull request
Dec 7, 2023
If not in cluster mode, there is no need to compute slot. A bit optimization for #12754
zuiderkwast
added a commit
to redis/redis-doc
that referenced
this pull request
Jan 18, 2024
Adding to the cluster spec documentation of the following Redis features: redis/redis#12754 (SCAN) redis/redis#12536 (KEYS) redis/redis#12728 (SORT, SORT_RO)
zuiderkwast
pushed a commit
to redis/redis-doc
that referenced
this pull request
Mar 7, 2024
The optimization done in redis/redis#12754.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #12536 we made a similar optimization for SCAN, now that hashtags in patterns. When we can make sure all keys matching the pettern will be in the same slot, we can limit the iteration to run only one one.