Add an explanation for URI with -u in redis-cli --help#12751
Merged
oranagra merged 4 commits intoredis:unstablefrom Nov 19, 2023
Merged
Add an explanation for URI with -u in redis-cli --help#12751oranagra merged 4 commits intoredis:unstablefrom
oranagra merged 4 commits intoredis:unstablefrom
Conversation
zuiderkwast
reviewed
Nov 10, 2023
zuiderkwast
reviewed
Nov 13, 2023
zuiderkwast
added
state:to-be-merged
zuiderkwast
changed the title
zuiderkwast
approved these changes
Nov 13, 2023
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks!
@redis/redis-committers, this is --help output only, safe to merge.
@lowgiant Regarding 80 characters width, Redis source code does not follow this in general, but for the terminal output I think it is nice to follow it, when we don't know the user's terminal size. (I hope you and others agree.)
Contributor
Author
|
@zuiderkwast I agree too. It was more organized, and I learned a lot. Thank you. |
enjoy-binbin
approved these changes
Nov 13, 2023
Contributor
|
@oranagra please merge. |
Contributor
Author
|
Hi @soloestoy Could you please look at this when you have sometime? |
oranagra
approved these changes
Nov 19, 2023
zuiderkwast
added a commit
to redis/redis-doc
that referenced
this pull request
Nov 22, 2023
It's good for users to know that they need to specify "default" as the username when authenticating without a username. Other details of the URI format are described too, like scheme and dbnum. Related to redis/redis#12751 Co-authored-by: Viktor Söderqvist <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation of the URI format in the
--helpoutput ofredis-cliandredis-benchmark.In particular, it's good for users to know that they need to specify "default" as the username when authenticating without a username. Other details of the URI format are described too, like scheme and dbnum.
It used to be possible to connect to Redis using an URL with an empty username, like
redis-cli -u redis://:PASSWORD@localhost:6379/0. This was broken in 6.2 (#8048), and there was a discussion about it #9186. Now, users need to specify "default" as the username and it's better to document it.Refer to #12746 for more details.