Support by/get options for sort(_ro) in cluster mode when pattern implies slot.#12728
Merged
oranagra merged 4 commits intoredis:unstablefrom Dec 13, 2023
Merged
Conversation
zuiderkwast
reviewed
Nov 6, 2023
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Nice. This is a semantic change, a different reply to the client in some cases. The SCAN PR was just an optimization, i.e. the same reply to the client as before.
This needs to be discussed by the core team.
CharlesChen888
force-pushed
the
cluster-support-sort-byget-hashtag
branch
from
c291c6e to
412c199
Compare
soloestoy
added
the
release-notes
oranagra
added
state:major-decision
oranagra
approved these changes
Nov 16, 2023
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
LGTM. needs core-team approval
Member
|
@redis/core-team as discussed in the meeting, please approve this one. |
soloestoy
approved these changes
Nov 29, 2023
madolson
approved these changes
Dec 5, 2023
zuiderkwast
approved these changes
Dec 5, 2023
Contributor
|
@oranagra I see the keys optimization merged, can this PR also be merged now? |
Member
|
@yossigo @itamarhaber please approve |
enjoy-binbin
approved these changes
Dec 7, 2023
itamarhaber
approved these changes
Dec 13, 2023
yossigo
approved these changes
Dec 13, 2023
zuiderkwast
added a commit
to redis/redis-doc
that referenced
this pull request
Jan 18, 2024
Adding to the cluster spec documentation of the following Redis features: redis/redis#12754 (SCAN) redis/redis#12536 (KEYS) redis/redis#12728 (SORT, SORT_RO)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The by/get options of sort/sort_ro command used to be forbidden in cluster mode, since we are not sure which slot the pattern may be in.
As the optimization done in #12536, patterns now can be mapped to slots, we should allow by/get options in cluster mode when the pattern maps to the same slot as the key.