re-enable defrag tests in cluster mode#12710
Merged
oranagra merged 2 commits intoredis:unstablefrom Nov 2, 2023
Merged
Conversation
enjoy-binbin
approved these changes
Oct 31, 2023
oranagra
reviewed
Oct 31, 2023
Member
oranagra
left a comment
There was a problem hiding this comment.
i think we should still skip these in cluster mode:
- Active defrag eval scripts
- Active defrag big list
- Active defrag edge case
they have a very specific aim, and don't make sense to run twice.
which means we'll keep:
- Active defrag main dictionary
- Active defrag - AOF loading
- Active defrag big keys
@hpatro let me know if you think i'm wrong.
Contributor
|
Hi @oranagra, I had kept the I would keep these three tests enabled for better coverage:
|
Contributor
|
We tried running with |
Member
|
so we can at least exclude
|
oranagra
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #12694 (comment)
This PR reverts the skipping defrag tests in cluster mode (done in #12672.
instead it skips only some defrag tests that are relevant for cluster modes.
The test now run well after investigating and making the changes in #12674 and #12694.