Skip to content

Add new loglevel nothing to sentinel-config.json#12235

Merged
oranagra merged 1 commit intoredis:unstablefrom
enjoy-binbin:fix_sentinel_loglevel_reply_test
May 26, 2023
Merged

Add new loglevel nothing to sentinel-config.json#12235
oranagra merged 1 commit intoredis:unstablefrom
enjoy-binbin:fix_sentinel_loglevel_reply_test

Conversation

@enjoy-binbin
Copy link
Contributor

It was missing in #12223, and the reply-schemas daily
was failing:

jsonschema.exceptions.ValidationError: 'nothing' is not valid under any of the given schemas

Failed validating 'oneOf' in schema[0]['properties']['loglevel']:
    {'oneOf': [{'const': 'debug'},
               {'const': 'verbose'},
               {'const': 'notice'},
               {'const': 'warning'},
               {'const': 'unknown'}]}

On instance['loglevel']:
    'nothing'

It was missing in redis#12223, and the reply-schemas daily
was failing:
```
jsonschema.exceptions.ValidationError: 'nothing' is not valid under any of the given schemas

Failed validating 'oneOf' in schema[0]['properties']['loglevel']:
    {'oneOf': [{'const': 'debug'},
               {'const': 'verbose'},
               {'const': 'notice'},
               {'const': 'warning'},
               {'const': 'unknown'}]}

On instance['loglevel']:
    'nothing'
```
@enjoy-binbin
Copy link
Contributor Author

didn’t know there were these replies listed before, and I will check more in the future

@enjoy-binbin enjoy-binbin requested a review from oranagra May 26, 2023 02:31
@oranagra oranagra merged commit e775b34 into redis:unstable May 26, 2023
@enjoy-binbin enjoy-binbin deleted the fix_sentinel_loglevel_reply_test branch May 26, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants