Normalize NAN to a single nan type, like we do with inf#11597
Merged
oranagra merged 4 commits intoredis:unstablefrom Dec 8, 2022
Merged
Normalize NAN to a single nan type, like we do with inf#11597oranagra merged 4 commits intoredis:unstablefrom
oranagra merged 4 commits intoredis:unstablefrom
Conversation
From https://en.wikipedia.org/wiki/NaN#Display, it says that apart from nan and -nan, we can also get NAN and even nan(char-sequence) from libc. In redis#11482, our conclusion was that we wanna normalize it in Redis to a single nan type, like we already normalized inf. For this, we also reverted the assert_match part of the test added in redis#11506, using assert_equal to validate the changes.
zuiderkwast
reviewed
Dec 8, 2022
enjoy-binbin
commented
Dec 8, 2022
oranagra
reviewed
Dec 8, 2022
oranagra
approved these changes
Dec 8, 2022
oranagra
added
the
release-notes
enjoy-binbin
added a commit
to enjoy-binbin/redis-specifications
that referenced
this pull request
Dec 9, 2022
In redis/redis#11597, Redis 7.2, we normalized NaN in Redis to a single nan type, like we already normalized inf.
oranagra
added a commit
to redis/redis-specifications
that referenced
this pull request
Jan 5, 2023
In redis/redis#11597, Redis 7.2, we normalized NaN in Redis to a single nan type, like we already normalized inf. Co-authored-by: Viktor Söderqvist <[email protected]> Co-authored-by: Oran Agra <[email protected]>
madolson
pushed a commit
to madolson/redis
that referenced
this pull request
Apr 19, 2023
From https://en.wikipedia.org/wiki/NaN#Display, it says that apart from nan and -nan, we can also get NAN and even nan(char-sequence) from libc. In redis#11482, our conclusion was that we wanna normalize it in Redis to a single nan type, like we already normalized inf. For this, we also reverted the assert_match part of the test added in redis#11506, using assert_equal to validate the changes.
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
From https://en.wikipedia.org/wiki/NaN#Display, it says that apart from nan and -nan, we can also get NAN and even nan(char-sequence) from libc. In redis#11482, our conclusion was that we wanna normalize it in Redis to a single nan type, like we already normalized inf. For this, we also reverted the assert_match part of the test added in redis#11506, using assert_equal to validate the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From https://en.wikipedia.org/wiki/NaN#Display, it says
that apart from nan and -nan, we can also get NAN and even
nan(char-sequence) from libc.
In #11482, our conclusion was that we wanna normalize it in
Redis to a single nan type, like we already normalized inf.
For this, we also reverted the assert_match part of the test
added in #11506, using assert_equal to validate the changes.