Fix sentinel issue if replica changes IP#11590
Merged
yossigo merged 1 commit intoredis:unstablefrom Dec 8, 2022
Merged
Conversation
yossigo
changed the title
yossigo
approved these changes
Dec 8, 2022
yossigo
added
the
release-notes
oranagra
pushed a commit
that referenced
this pull request
Jan 16, 2023
As Sentinel supports dynamic IP only when using hostnames, there are few leftover addess comparison logic that doesn't take into account that the IP might get change. Co-authored-by: moticless <[email protected]> (cherry picked from commit 4a27aa4)
oranagra
pushed a commit
that referenced
this pull request
Jan 16, 2023
As Sentinel supports dynamic IP only when using hostnames, there are few leftover addess comparison logic that doesn't take into account that the IP might get change. Co-authored-by: moticless <[email protected]> (cherry picked from commit 4a27aa4)
madolson
pushed a commit
to madolson/redis
that referenced
this pull request
Apr 19, 2023
As Sentinel supports dynamic IP only when using hostnames, there are few leftover addess comparison logic that doesn't take into account that the IP might get change. Co-authored-by: moticless <[email protected]>
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
As Sentinel supports dynamic IP only when using hostnames, there are few leftover addess comparison logic that doesn't take into account that the IP might get change. Co-authored-by: moticless <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Sentinel support dynamic IP only when using hostnames, there
are few leftover addess comparison logic that doesn't take into
account that the IP might get change.
I did a limited fix in the past to same issue on another location but
was too lazy or wasn't sure to fully review the code for othe places.
Hope it will cover entirely this time.
Fixes issue: #9998 (read from here).