Merged
Conversation
* Remove duplicate code, propagating SSL errors into connection state. * Add missing error handling in synchronous IO functions. * Fix connection error reporting in some replication flows.
yossigo
added
the
release-notes
oranagra
approved these changes
Dec 1, 2022
Merged
oranagra
pushed a commit
that referenced
this pull request
Dec 12, 2022
* Remove duplicate code, propagating SSL errors into connection state. * Add missing error handling in synchronous IO functions. * Fix connection error reporting in some replication flows. (cherry picked from commit 155acef)
madolson
pushed a commit
to madolson/redis
that referenced
this pull request
Apr 19, 2023
* Remove duplicate code, propagating SSL errors into connection state. * Add missing error handling in synchronous IO functions. * Fix connection error reporting in some replication flows.
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
* Remove duplicate code, propagating SSL errors into connection state. * Add missing error handling in synchronous IO functions. * Fix connection error reporting in some replication flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background for this work is CI failures on arm64, such as this one:
https://github.com/redis/redis-extra-ci/actions/runs/3537044170/jobs/5936665499
The test fails as it expects the replica to hit the timeout, but instead, the connection drops and reconnects later. The replica reports connection errors:
These errors are potentially misleading because they're derived from
errnoand not from the underlying connection, which, in turn, needs to consult OpenSSL.This PR may fix the root cause or provide more accurate error logging to help track the underlying problem.