Regenerate payloads for cgroups tests using string2printable#11560
Regenerate payloads for cgroups tests using string2printable#11560oranagra merged 2 commits intoredis:unstablefrom
Conversation
The test failed with `ERR DUMP payload version or checksum are wrong.` And it only fails on CentOS, i guess this payload is not suitable on CentOS. Payload regenerated using string2printable, introduced in redis#11099
|
This is due to the fact that tcl8.5 does not correctly parse the hexadecimal abbreviation. |
|
oh, so that's the case, I vaguely remember seeing this question before, thanks for the tip btw, why only centos, can you recall it? I guess all our CIs use tcl8.5 |
|
some is using 8.6 and others are not, like ubuntu |
There was a problem hiding this comment.
yes, TCL 8.5 can only correctly handle \x if the entire string is escaped. it can't mix escaping and plain chars in the same string.
but i see this payload was completely changed (started with \x13 and now it starts with \x15).
i.e.
- it's not that we just fixed the escaping, it's a different content.
- how did we generate it? is it still the old RDB format? seems like we changed it from RDB_TYPE_STREAM_LISTPACKS_2 to RDB_TYPE_STREAM_LISTPACKS_3
i used a trick, like i used to do in corrupt payload one. and now i see, the rdb type is the wrong one |
oranagra
left a comment
There was a problem hiding this comment.
good that i caught it, otherwise this test would be completely missing its purpose. 8-)
p.s. you could also just use TCL8.6 to pass that string through string2printable
|
was a bit quick on the trigger with my +1 😂 |
…1560) The test failed with ERR DUMP payload version or checksum are wrong. And it only fails on CentOS, this is due to the fact that tcl8.5 does not correctly parse the hexadecimal abbreviation. And in Ubuntu we are using tcl8.6.
…1560) The test failed with ERR DUMP payload version or checksum are wrong. And it only fails on CentOS, this is due to the fact that tcl8.5 does not correctly parse the hexadecimal abbreviation. And in Ubuntu we are using tcl8.6.
The test failed with
ERR DUMP payload version or checksum are wrong.And it only fails on CentOS, this is due to the fact that tcl8.5 does not correctly
parse the hexadecimal abbreviation. And in Ubuntu we are using tcl8.6.
Payload regenerated using string2printable, introduced in #11099