Speedup GEODIST with fixedpoint_d2string as an optimized version of snprintf %.4f#11552
Merged
oranagra merged 7 commits intoredis:unstablefrom Dec 4, 2022
Merged
Conversation
filipecosta90
added
the
action:run-benchmark
Contributor
Author
oranagra
reviewed
Dec 1, 2022
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
on a first glance, it looks scary, too much low level code to replace something simple.
however, reading the explanation of the decimal point shift i think it's neat.
maybe if we can move that function to utils.c and generalize it a bit, then i'd feel better.
i.e. int fixedpoint_d2string(char *buf, size_t len, double value, int fractional_digits)
then it'll be a generic optimized algorithm like our ull2string, and not some special geo hack that's going too deep.
oranagra
reviewed
Dec 2, 2022
oranagra
reviewed
Dec 3, 2022
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
another (last) round of comments.
only now i actually reviewed the implementation code, and not just the general concept.
Co-authored-by: Oran Agra <[email protected]>
Contributor
Author
|
@oranagra followed the recommendations and updated the numbers on the PR description. |
oranagra
approved these changes
Dec 4, 2022
oranagra
changed the title
Merged
oranagra
added a commit
that referenced
this pull request
Dec 12, 2022
…nprintf %.4f (#11552) GEODIST used snprintf("%.4f") for the reply using addReplyDoubleDistance, which was slow. This PR optimizes it without breaking compatibility by following the approach of ll2string with some changes to match the use case of distance and precision. I.e. we multiply it by 10000 format it as an integer, and then add a decimal point. This can achieve about 35% increase in the achievable ops/sec. Co-authored-by: Oran Agra <[email protected]> (cherry picked from commit 61c85a2)
madolson
pushed a commit
to madolson/redis
that referenced
this pull request
Apr 19, 2023
…nprintf %.4f (redis#11552) GEODIST used snprintf("%.4f") for the reply using addReplyDoubleDistance, which was slow. This PR optimizes it without breaking compatibility by following the approach of ll2string with some changes to match the use case of distance and precision. I.e. we multiply it by 10000 format it as an integer, and then add a decimal point. This can achieve about 35% increase in the achievable ops/sec. Co-authored-by: Oran Agra <[email protected]>
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
…nprintf %.4f (redis#11552) GEODIST used snprintf("%.4f") for the reply using addReplyDoubleDistance, which was slow. This PR optimizes it without breaking compatibility by following the approach of ll2string with some changes to match the use case of distance and precision. I.e. we multiply it by 10000 format it as an integer, and then add a decimal point. This can achieve about 35% increase in the achievable ops/sec. Co-authored-by: Oran Agra <[email protected]>
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
…dis#11631) Fixes a regression introduced by redis#11552 in 7.0.6. it causes replies in the GEO commands to contain garbage when the result is a very small distance (less than 1) Includes test to confirm indeed with junk in buffer now we properly reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEODIST used snprintf("%.4f") for the reply using addReplyDoubleDistance, which was slow.
This PR optimizes it without breaking compatibility by following the approach of ll2string with some changes to match the use case of distance and precision.
I.e. we multiply it by 10000 format it as an integer, and then add a decimal point.
This can achieve about 35% increase in the achievable ops/sec.
Details
Out of the 36.44% geodistCommand CPU cycles we can pinpoint 26.02% to addReplyDoubleDistance:
To functionally test it:
To benchmark:
Use the following RDB with 60M datapoints on the GEO key. https://s3.us-east-2.amazonaws.com/redis.benchmarks.spec/datasets/geopoint/dump.rdb
unstable branch ( 155acef )
this PR (c7bb268)
Approximately 35% increase in the achievable ops/sec.