Fix replication on expired key test timing issue, give it more chances#11548
Merged
oranagra merged 2 commits intoredis:unstablefrom Nov 28, 2022
Merged
Conversation
In replica, the key expired before master's `INCR` was arrived, so INCR
creates a new key in the replica and the test failed.
```
*** [err]: Replication of an expired key does not delete the expired key in tests/integration/replication-4.tcl
Expected '0' to be equal to '1' (context: type eval line 13 cmd {assert_equal 0 [$slave exists k]} proc ::test)
```
This test is very likely to do a false positive if the `wait_for_ofs_sync`
takes longer than the expiration time, so give it a few more chances.
The test was introduced in redis#9572.
Contributor
Author
|
First reported at #9572 (review) |
Contributor
|
I guess there is no way to make it pass every time, so retrying the test case 10 times sounds good. How about increasing the TTL of k, would that make it fail less often? |
Contributor
Author
i guess it will, but then we also need to increase the time of after, so I think a simple retry can make it work better |
Member
|
thank you for taking care of this. i think that if we bother to fix it, maybe instead of 10 retries of 1 second (which could still repeatedly fail on a slow system), i'd rather go with 5 retries of increasing timeout. |
oranagra
approved these changes
Nov 28, 2022
oranagra
pushed a commit
that referenced
this pull request
Dec 12, 2022
#11548) In replica, the key expired before master's `INCR` was arrived, so INCR creates a new key in the replica and the test failed. ``` *** [err]: Replication of an expired key does not delete the expired key in tests/integration/replication-4.tcl Expected '0' to be equal to '1' (context: type eval line 13 cmd {assert_equal 0 [$slave exists k]} proc ::test) ``` This test is very likely to do a false positive if the `wait_for_ofs_sync` takes longer than the expiration time, so give it a few more chances. The test was introduced in #9572. (cherry picked from commit 06b577a)
madolson
pushed a commit
to madolson/redis
that referenced
this pull request
Apr 19, 2023
redis#11548) In replica, the key expired before master's `INCR` was arrived, so INCR creates a new key in the replica and the test failed. ``` *** [err]: Replication of an expired key does not delete the expired key in tests/integration/replication-4.tcl Expected '0' to be equal to '1' (context: type eval line 13 cmd {assert_equal 0 [$slave exists k]} proc ::test) ``` This test is very likely to do a false positive if the `wait_for_ofs_sync` takes longer than the expiration time, so give it a few more chances. The test was introduced in redis#9572.
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
redis#11548) In replica, the key expired before master's `INCR` was arrived, so INCR creates a new key in the replica and the test failed. ``` *** [err]: Replication of an expired key does not delete the expired key in tests/integration/replication-4.tcl Expected '0' to be equal to '1' (context: type eval line 13 cmd {assert_equal 0 [$slave exists k]} proc ::test) ``` This test is very likely to do a false positive if the `wait_for_ofs_sync` takes longer than the expiration time, so give it a few more chances. The test was introduced in redis#9572.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In replica, the key expired before master's
INCRwas arrived, so INCRcreates a new key in the replica and the test failed.
This test is very likely to do a false positive if the
wait_for_ofs_synctakes longer than the expiration time, so give it a few more chances.
Go with 5 retries of increasing timeout, i.e. start with 500ms, then go
to 1000ms, 2000ms, 4000ms, 8000ms.
The test was introduced in #9572
Also it fixes #11153