Skip to content

Add missing lpFree for listpack test, fix valgrind daily#11492

Merged
oranagra merged 1 commit intoredis:unstablefrom
enjoy-binbin:fix_listpack_test
Nov 10, 2022
Merged

Add missing lpFree for listpack test, fix valgrind daily#11492
oranagra merged 1 commit intoredis:unstablefrom
enjoy-binbin:fix_listpack_test

Conversation

@enjoy-binbin
Copy link
Contributor

Add missing lpFree, introduced in #11290

@enjoy-binbin
Copy link
Contributor Author

reported in daily CI
test-sanitizer-address (gcc)
test-valgrind-misc

==48787==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 5193 byte(s) in 1 object(s) allocated from:
    #0 0x7f82c267fc3e in __interceptor_realloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:163
    #1 0x55b1527c63ca in ztryrealloc_usable /home/runner/work/redis/redis/src/zmalloc.c:249
    #2 0x55b1527c63ca in ztryrealloc_usable /home/runner/work/redis/redis/src/zmalloc.c:223
    #3 0x55b1527c63ca in zrealloc /home/runner/work/redis/redis/src/zmalloc.c:279
    #4 0x55b152a73120 in lpInsert /home/runner/work/redis/redis/src/listpack.c:855
    #5 0x55b152a73120 in lpAppend /home/runner/work/redis/redis/src/listpack.c:966
    #6 0x55b152a89a42 in listpackTest /home/runner/work/redis/redis/src/listpack.c:2207
    #7 0x55b152746d7e in main /home/runner/work/redis/redis/src/server.c:6837
    #8 0x7f82c2222082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082)

Direct leak of 22 byte(s) in 1 object(s) allocated from:
    #0 0x7f82c267fc3e in __interceptor_realloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:163
    #1 0x55b1527c63ca in ztryrealloc_usable /home/runner/work/redis/redis/src/zmalloc.c:249
    #2 0x55b1527c63ca in ztryrealloc_usable /home/runner/work/redis/redis/src/zmalloc.c:223
    #3 0x55b1527c63ca in zrealloc /home/runner/work/redis/redis/src/zmalloc.c:279
    #4 0x55b152a73120 in lpInsert /home/runner/work/redis/redis/src/listpack.c:855
    #5 0x55b152a73120 in lpAppend /home/runner/work/redis/redis/src/listpack.c:966
    #6 0x55b152a89d18 in listpackTest /home/runner/work/redis/redis/src/listpack.c:2239
    #7 0x55b152746d7e in main /home/runner/work/redis/redis/src/server.c:6837
    #8 0x7f82c2222082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082)

SUMMARY: AddressSanitizer: 5215 byte(s) leaked in 2 allocation(s).

@oranagra oranagra merged commit 6617f17 into redis:unstable Nov 10, 2022
@enjoy-binbin enjoy-binbin deleted the fix_listpack_test branch November 10, 2022 08:28
madolson pushed a commit to madolson/redis that referenced this pull request Apr 19, 2023
enjoy-binbin added a commit to enjoy-binbin/redis that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants