fix infinite sleep in performEvictions when have lazyfree jobs#11237
Merged
oranagra merged 1 commit intoredis:unstablefrom Sep 18, 2022
Merged
fix infinite sleep in performEvictions when have lazyfree jobs#11237oranagra merged 1 commit intoredis:unstablefrom
oranagra merged 1 commit intoredis:unstablefrom
Conversation
oranagra
approved these changes
Sep 5, 2022
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
LGTM.
let's wait a bit to see if there are any comments by others though.
oranagra
added
the
release-notes
madolson
approved these changes
Sep 5, 2022
soloestoy
force-pushed
the
bugfix-infinite-sleep-when-evcit
branch
from
c2e7756 to
5428cf1
Compare
JimB123
approved these changes
Sep 6, 2022
Contributor
JimB123
left a comment
JimB123
left a comment
There was a problem hiding this comment.
LGTM. Did someone actually try setting this to 100?
Contributor
Author
me, and almost all users in our platform. |
Collaborator
|
@soloestoy Did you consider adding a test? |
Contributor
Author
@yossigo I tried, but we cannot make lazyfree and eviction atomic, since the lazyfree time is nondeterministic, do you have another way to test it? |
Merged
oranagra
pushed a commit
that referenced
this pull request
Sep 21, 2022
This bug is introduced in #7653. (Redis 6.2.0) When `server.maxmemory_eviction_tenacity` is 100, `eviction_time_limit_us` is `ULONG_MAX`, and if we cannot find the best key to delete (e.g. maxmemory-policy is `volatile-lru` and all keys with ttl have been evicted), in `cant_free` redis will sleep forever if some items are being freed in the lazyfree thread. (cherry picked from commit 464aa04)
Merged
oranagra
pushed a commit
that referenced
this pull request
Dec 12, 2022
This bug is introduced in #7653. (Redis 6.2.0) When `server.maxmemory_eviction_tenacity` is 100, `eviction_time_limit_us` is `ULONG_MAX`, and if we cannot find the best key to delete (e.g. maxmemory-policy is `volatile-lru` and all keys with ttl have been evicted), in `cant_free` redis will sleep forever if some items are being freed in the lazyfree thread. (cherry picked from commit 464aa04)
madolson
pushed a commit
to madolson/redis
that referenced
this pull request
Apr 19, 2023
…#11237) This bug is introduced in redis#7653. (Redis 6.2.0) When `server.maxmemory_eviction_tenacity` is 100, `eviction_time_limit_us` is `ULONG_MAX`, and if we cannot find the best key to delete (e.g. maxmemory-policy is `volatile-lru` and all keys with ttl have been evicted), in `cant_free` redis will sleep forever if some items are being freed in the lazyfree thread.
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
…#11237) This bug is introduced in redis#7653. (Redis 6.2.0) When `server.maxmemory_eviction_tenacity` is 100, `eviction_time_limit_us` is `ULONG_MAX`, and if we cannot find the best key to delete (e.g. maxmemory-policy is `volatile-lru` and all keys with ttl have been evicted), in `cant_free` redis will sleep forever if some items are being freed in the lazyfree thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug is introduced in #7653. (Redis 6.2.0)
When
server.maxmemory_eviction_tenacityis 100,eviction_time_limit_usisULONG_MAX, and if we cannot find the best key to delete (e.g. maxmemory-policy isvolatile-lruand all keys with ttl have been evicted), incant_freeredis will sleep forever if some items are being freed in the lazyfree thread.