Skip to content

Fix cluster hostnames test causing failover while running valgrind#10991

Merged
oranagra merged 2 commits intoredis:unstablefrom
madolson:valgrind-hostnames
Jul 17, 2022
Merged

Fix cluster hostnames test causing failover while running valgrind#10991
oranagra merged 2 commits intoredis:unstablefrom
madolson:valgrind-hostnames

Conversation

@madolson
Copy link
Contributor

@madolson madolson commented Jul 16, 2022

In the newly added cluster hostnames test, the primary is failing over during the reboot for valgrind so we are validating the wrong node. This change just sets the replica to prevent taking over, which seems to fix the test.

We could have also set the timeout higher, but it slows down the test.

dev-dsk-matolson-2c-96119f9f % ./runtest --valgrind --no-latency --verbose --clients 1 --timeout 2400 --dump-logs --single unit/cluster/hostnames
Cleanup: may take some time... OK
Starting test server at port 21079
[ready]: 22670
Testing unit/cluster/hostnames
=== (external:skip cluster) Starting server 127.0.0.1:21111 ok
=== (external:skip cluster) Starting server 127.0.0.1:21112 ok
=== (external:skip cluster) Starting server 127.0.0.1:21113 ok
=== (external:skip cluster) Starting server 127.0.0.1:21114 ok
=== (external:skip cluster) Starting server 127.0.0.1:21115 ok
=== (external:skip cluster) Starting server 127.0.0.1:21116 ok
=== (external:skip cluster) Starting server 127.0.0.1:21117 ok
[ok]: Set cluster hostnames and verify they are propagated (1108 ms)
[ok]: Update hostnames and make sure they are all eventually propagated (862 ms)
[ok]: Remove hostnames and make sure they are all eventually propagated (963 ms)
[ok]: Verify cluster-preferred-endpoint-type behavior for redirects and info (993 ms)
[ok]: Verify the nodes configured with prefer hostname only show hostname for new nodes (3161 ms)
[ok]: Test restart will keep hostname information (2562 ms)
[ok]: Test hostname validation (17 ms)
[1/1 done]: unit/cluster/hostnames (27 seconds)

                   The End

Execution time of different units:
  27 seconds - unit/cluster/hostnames

@madolson madolson mentioned this pull request Jul 17, 2022
Merged
@oranagra oranagra merged commit 3abdec9 into redis:unstable Jul 17, 2022
enjoy-binbin pushed a commit to enjoy-binbin/redis that referenced this pull request Jul 31, 2023
@madolson @enjoy-binbin
Fix cluster hostnames test causing failover while running valgrind (r…
5a9cd66 
…edis#10991)

In the newly added cluster hostnames test, the primary is failing over during the reboot
for valgrind so we are validating the wrong node. This change just sets the replica to
prevent taking over, which seems to fix the test.

We could have also set the timeout higher, but it slows down the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oranagra oranagra oranagra approved these changes

+1 more reviewer

@enjoy-binbin enjoy-binbin enjoy-binbin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@madolson @oranagra @enjoy-binbin