Skip to content

Add an option to specify multiple skip files using --skipfile#10975

Merged
oranagra merged 1 commit intoredis:unstablefrom
valentinogeron:multiple-skip-file
Jul 17, 2022
Merged

Add an option to specify multiple skip files using --skipfile#10975
oranagra merged 1 commit intoredis:unstablefrom
valentinogeron:multiple-skip-file

Conversation

@valentinogeron
Copy link
Contributor

--skipfile can be repeated.
For example: ./runtests --skipfile file1.txt --skipfile file2.txt

`--skipfile` can be repeated.
For example: ./runtests --skipfile file1.txt --skipfile file2.txt
@sundb
Copy link
Collaborator

sundb commented Jul 14, 2022

--skipfile support regexp patterns, maybe (file1|file2) is avaliable.
Why not put all the test names that you want to filter in the same file?
Perhap cat file1.txt file2.txt > file3.txt & ./runtests --skipfile file3.txt also available for your needs.

@oranagra
Copy link
Member

@sundb we have a case where the test execution is wrapped in some bash script that adds some argument automatically (including a skip file), and then, the caller may want to add a skip file of his own.
considering how simple it is to just support multiple file, i don't see why we shouldn't just support it..

@oranagra oranagra merged commit 847cdca into redis:unstable Jul 17, 2022
enjoy-binbin pushed a commit to enjoy-binbin/redis that referenced this pull request Jul 31, 2023
…s#10975)

`--skipfile` can be repeated.
For example: ./runtests --skipfile file1.txt --skipfile file2.txt

Co-authored-by: Valentino Geron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants