Fix wrong commands json docs for CLIENT KILL#10970
Merged
oranagra merged 2 commits intoredis:unstablefrom Aug 1, 2022
Merged
Conversation
oranagra
approved these changes
Jul 13, 2022
oranagra
reviewed
Jul 17, 2022
The docs state that there is a new and an old argument format. The current state of the arguments allows mixing the old and new format, thus the need for two additional oneof blocks. One for differentiating the new from the old format and then one to allow setting multiple filters using the new format.
guybe7
reviewed
Jul 19, 2022
oranagra
pushed a commit
that referenced
this pull request
Sep 21, 2022
The docs state that there is a new and an old argument format. The current state of the arguments allows mixing the old and new format, thus the need for two additional oneof blocks. One for differentiating the new from the old format and then one to allow setting multiple filters using the new format. (cherry picked from commit 4ce3fd5)
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
The docs state that there is a new and an old argument format. The current state of the arguments allows mixing the old and new format, thus the need for two additional oneof blocks. One for differentiating the new from the old format and then one to allow setting multiple filters using the new format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR originates from #10948
The docs state that there is a new and an old argument format.
The current state of the arguments allows mixing the old and new format, thus the need for two additional
oneofblocks.One for differentiating the new from the old format and then a inner one to allow setting multiple filters using the new format.
I also changed the name of the old format in accordance with the new format
oneofto make that clearer in the docs.