Skip to content

Fix BZMPOP gets unblocked by non-key args and returns them#10764

Merged
oranagra merged 3 commits intoredis:unstablefrom
enjoy-binbin:bzmpop_blocking_bug_issue_10762
May 23, 2022
Merged

Fix BZMPOP gets unblocked by non-key args and returns them#10764
oranagra merged 3 commits intoredis:unstablefrom
enjoy-binbin:bzmpop_blocking_bug_issue_10762

Conversation

@enjoy-binbin
Copy link
Contributor

@enjoy-binbin enjoy-binbin commented May 23, 2022

This bug was introduced in #9484 (7.0.0).
It result that BZMPOP blocked on non-key arguments.

Like bzmpop 0 1 myzset min count 10, this command will additionally
block in these keys (except for the first and the last argument) and can return their values:

  • 0: timeout value
  • 1: numkeys value
  • min: min/max token
  • count: count token

Fixes #10762

This bug was introduced in redis#9484 (7.0.0).
It result that BZMPOP blocked on non-key arguments.

Like `bzmpop 0 1 myzset min count 10`, this command will additionally
block in these keys (except for the first and the last argument):
- 0: timeout value
- 1: numkeys value
- min: min/max token
- count: count token

Fixes redis#10762
@oranagra oranagra changed the title Fix BZMPOP blocked on non-key arguments bug Fix BZMPOP gets unblocked by non-key args and returns them May 23, 2022
@oranagra oranagra merged commit 450c88f into redis:unstable May 23, 2022
@oranagra oranagra added the release-notes indication that this issue needs to be mentioned in the release notes label May 23, 2022
@enjoy-binbin enjoy-binbin deleted the bzmpop_blocking_bug_issue_10762 branch May 23, 2022 11:34
@oranagra oranagra mentioned this pull request Jun 8, 2022
enjoy-binbin added a commit to enjoy-binbin/redis that referenced this pull request Jul 31, 2023
This bug was introduced in redis#9484 (7.0.0).
It result that BZMPOP blocked on non-key arguments.

Like `bzmpop 0 1 myzset min count 10`, this command will additionally
block in these keys (except for the first and the last argument) and can return their values:
- 0: timeout value
- 1: numkeys value
- min: min/max token
- count: count token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes indication that this issue needs to be mentioned in the release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] BZMPOP blocks on non key arguments

2 participants