Fix memory leak in streamGetEdgeID#10753
Merged
oranagra merged 1 commit intoredis:unstablefrom May 22, 2022
Merged
Conversation
si is initialized by streamIteratorStart(), we should call streamIteratorStop() on it when done.
enjoy-binbin
added
the
state:to-be-merged
enjoy-binbin
approved these changes
May 19, 2022
oranagra
approved these changes
May 22, 2022
Member
|
@Yuuoniy thank you. this looks like a regression in redis 7.0 (#9127) that could in cause leaks in trimming (XADD, XTRIM), and also XDEL and AOFRW. @itamarhaber @guybe7 correct me if i'm wrong. |
oranagra
added
the
release-notes
Contributor
Author
Merged
Member
|
Apparently there's a CVE for this issue: GHSA-35rf-7vhx-9phr |
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
si is initialized by streamIteratorStart(), we should call streamIteratorStop() on it when done. regression introduced in redis#9127 (redis 7.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
si is initialized by streamIteratorStart(), we should call streamIteratorStop() on it when done. #10752