fix broken protocol regression from #10612#10639
Merged
oranagra merged 2 commits intoredis:unstablefrom Apr 25, 2022
oranagra:fix_broken_protocol
Merged
fix broken protocol regression from #10612#10639oranagra merged 2 commits intoredis:unstablefrom oranagra:fix_broken_protocol
oranagra merged 2 commits intoredis:unstablefrom
oranagra:fix_broken_protocol
Conversation
when replying with garbage bytes to the caller, we must make sure it doesn't include any newlines.
madolson
reviewed
Apr 25, 2022
madolson
approved these changes
Apr 25, 2022
Contributor
madolson
left a comment
madolson
left a comment
There was a problem hiding this comment.
Approving to unblock in either case.
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
A change in redis#10612 introduced a regression. when replying with garbage bytes to the caller, we must make sure it doesn't include any newlines. in the past it called rejectCommandFormat which did that trick. but now it calls rejectCommandSds, which doesn't, so we need to make sure to sanitize the sds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change in #10612 introduced a regression.
when replying with garbage bytes to the caller, we must make sure it
doesn't include any newlines.
in the past it called rejectCommandFormat which did that trick.
but now it calls rejectCommandSds, which doesn't, so we need to make sure
to sanitize the sds.