Fix regression not aborting transaction on error, and re-edit some error responses#10612
Merged
oranagra merged 1 commit intoredis:unstablefrom Apr 25, 2022
Merged
Fix regression not aborting transaction on error, and re-edit some error responses#10612oranagra merged 1 commit intoredis:unstablefrom
oranagra merged 1 commit intoredis:unstablefrom
Conversation
1. RM_Call will reply the same way Redis does, in case of non-exisitng command or arity error 2. RM_WrongArtiy will consider the full command name Other changes: 1. Use lowercase 'u' in "unknonw subcommand" (to align with "unknown command")
Member
|
This is a followup work of #10127, which is part of redis 7.0, and at the time was approved as a major decision and marked for release notes. |
oranagra
approved these changes
Apr 24, 2022
Member
oranagra
left a comment
oranagra
left a comment
There was a problem hiding this comment.
@yossigo please tell me if you think this should be a major decision (i'm considering it's a followup work before the GA i'm leaning towards, no).
and please tell me which of these do you think should be on the release notes, if any.
Collaborator
|
@oranagra I think this is follow up work indeed, but changed error reply messages should be mentioned in the release notes. |
yossigo
approved these changes
Apr 25, 2022
oranagra
added
the
release-notes
oranagra
changed the title
Contributor
enjoy-binbin
left a comment
enjoy-binbin
left a comment
There was a problem hiding this comment.
don't know why, but look like this commit will hang the daily test (corrupt-dump-fuzzer)
Member
|
here's the fix: #10639 |
oranagra
added a commit
that referenced
this pull request
Apr 25, 2022
A change in #10612 introduced a regression. when replying with garbage bytes to the caller, we must make sure it doesn't include any newlines. in the past it called rejectCommandFormat which did that trick. but now it calls rejectCommandSds, which doesn't, so we need to make sure to sanitize the sds.
Merged
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
…ror responses (redis#10612) 1. Disk error and slave count checks didn't flag the transactions or counted correctly in command stats (regression from redis#10372 , 7.0 RC3) 2. RM_Call will reply the same way Redis does, in case of non-exisitng command or arity error 3. RM_WrongArtiy will consider the full command name 4. Use lowercase 'u' in "unknonw subcommand" (to align with "unknown command") Followup work of redis#10127
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
A change in redis#10612 introduced a regression. when replying with garbage bytes to the caller, we must make sure it doesn't include any newlines. in the past it called rejectCommandFormat which did that trick. but now it calls rejectCommandSds, which doesn't, so we need to make sure to sanitize the sds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup work of #10127