introduce MAX_D2STRING_CHARS instead of 128 const#10487
Merged
oranagra merged 2 commits intoredis:unstablefrom Mar 28, 2022
oranagra:max_d2string_chars
Merged
introduce MAX_D2STRING_CHARS instead of 128 const#10487oranagra merged 2 commits intoredis:unstablefrom oranagra:max_d2string_chars
oranagra merged 2 commits intoredis:unstablefrom
oranagra:max_d2string_chars
Conversation
yossigo
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few places that use a hard coded const of 128 to allocate a buffer for d2string.
Replace these with a clear macro.
Note that In theory, converting double into string could take as much as nearly 400 chars, but since d2string uses
%gand not%f, it won't pass some 40 chars.unrelated:
restore some changes to auto generated commands.c that got accidentally reverted in #10293