Fix timing issue in sentinel reconnect test#10424
Merged
yossigo merged 1 commit intoredis:unstablefrom Mar 14, 2022
Merged
Conversation
We need to wait for `sentinelTimer` to kick in, and then trigger the reconnect. As for another change, i think we should better call `server_set_password` before calling SENTINEL SET auth-pass. Introduced in redis#10400
Contributor
Author
|
the one that failed: https://github.com/enjoy-binbin/redis/actions/runs/1976493913/attempts/1 |
enjoy-binbin
added
the
state:to-be-merged
moticless
approved these changes
Mar 13, 2022
yossigo
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to wait for
sentinelTimerto kick in, and thentrigger the reconnect.
As for another change, i think we should better call
server_set_passwordbefore calling SENTINEL SET auth-pass.Introduced in #10400