remove a piece of redundant comment#10392
Merged
oranagra merged 3 commits intoredis:unstablefrom Mar 8, 2022
Merged
Conversation
oranagra
reviewed
Mar 8, 2022
src/acl.c
Outdated
Comment on lines
124
to
125
| * WARNING: Allowing a first arg of an otherwise blocked command is a misuse of ACL | ||
| * and may get disabled in the future. |
Member
There was a problem hiding this comment.
i'm not certain the warning is needed here.
this information is already present in both redis.conf, and also in the comment above ACLSetSelector.
we should either copy the same text from there, or better yet, trim some excessive info from, but not add more.
i see two valid options:
- trim just the outdated line, the one that mentions
loglevel, but keep theselectexample which is still valid. - trim the
selectexample lines too, but IMHO no need to add any additional repeated info.
oranagra
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduced in #10147 since we blocked the first-arg mechanism on subcommands