dismiss COW of client output buffer now that it's dynamic#10371
Merged
oranagra merged 1 commit intoredis:unstablefrom Mar 8, 2022
oranagra:dismiss_client_static_reply_buf
Merged
dismiss COW of client output buffer now that it's dynamic#10371oranagra merged 1 commit intoredis:unstablefrom oranagra:dismiss_client_static_reply_buf
oranagra merged 1 commit intoredis:unstablefrom
oranagra:dismiss_client_static_reply_buf
Conversation
yossigo
approved these changes
Mar 3, 2022
sundb
reviewed
Mar 9, 2022
| void dismissClientMemory(client *c) { | ||
| /* Dismiss client query buffer. */ | ||
| /* Dismiss client query buffer and static reply buffer. */ | ||
| dismissSds(c->buf); |
Collaborator
There was a problem hiding this comment.
crash CI in 32bit: https://github.com/redis/redis/runs/5473064515?check_suite_focus=true
c->buf is not sds.
oranagra
pushed a commit
that referenced
this pull request
Mar 9, 2022
c->buf is not sds, so we should use dismissMemory instead of dismissSds to dismiss it. This is a recent regression from #10371
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since #9822, the static reply buffer is no longer part of the client structure, so we need to dismiss it.