Skip to content

Fix XGROUP HELP message missing a newline#10339

Merged
oranagra merged 1 commit intoredis:unstablefrom
enjoy-binbin:xgroup_help
Feb 24, 2022
Merged

Fix XGROUP HELP message missing a newline#10339
oranagra merged 1 commit intoredis:unstablefrom
enjoy-binbin:xgroup_help

Conversation

@enjoy-binbin
Copy link
Contributor

Add a comma, this would have resulted in missing newline in the message.
Forgot to add in #9127

Add a comma, this would have resulted in missing newline in the message.
Forgot to add in redis#9127
@enjoy-binbin
Copy link
Contributor Author

before:

127.0.0.1:6379> xgroup help
 1) XGROUP <subcommand> [<arg> [value] [opt] ...]. Subcommands are:
 2) CREATE <key> <groupname> <id|$> [option]
 3)     Create a new consumer group. Options are:
 4)     * MKSTREAM
 5)       Create the empty stream if it does not exist.
 6)     * ENTRIESREAD entries_read
 7)       Set the group's entries_read counter (internal use).CREATECONSUMER <key> <groupname> <consumer>
 8)     Create a new consumer in the specified group.
 9) DELCONSUMER <key> <groupname> <consumer>
10)     Remove the specified consumer.
11) DESTROY <key> <groupname>
12)     Remove the specified group.
13) SETID <key> <groupname> <id|$> [ENTRIESREAD entries_read]
14)     Set the current group ID and entries_read counter.
15) HELP
16)     Prints this help.

after:

127.0.0.1:6379> xgroup help
 1) XGROUP <subcommand> [<arg> [value] [opt] ...]. Subcommands are:
 2) CREATE <key> <groupname> <id|$> [option]
 3)     Create a new consumer group. Options are:
 4)     * MKSTREAM
 5)       Create the empty stream if it does not exist.
 6)     * ENTRIESREAD entries_read
 7)       Set the group's entries_read counter (internal use).
 8) CREATECONSUMER <key> <groupname> <consumer>
 9)     Create a new consumer in the specified group.
10) DELCONSUMER <key> <groupname> <consumer>
11)     Remove the specified consumer.
12) DESTROY <key> <groupname>
13)     Remove the specified group.
14) SETID <key> <groupname> <id|$> [ENTRIESREAD entries_read]
15)     Set the current group ID and entries_read counter.
16) HELP
17)     Prints this help.

@enjoy-binbin enjoy-binbin added the state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten label Feb 24, 2022
@oranagra oranagra merged commit b4079ab into redis:unstable Feb 24, 2022
@enjoy-binbin enjoy-binbin deleted the xgroup_help branch February 24, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants