Skip to content

Enable redis-benchmark to use RESP3 protocol mode#10335

Merged
oranagra merged 2 commits intoredis:unstablefrom
filipecosta90:redisbenchmark.resp3
Feb 27, 2022
Merged

Enable redis-benchmark to use RESP3 protocol mode#10335
oranagra merged 2 commits intoredis:unstablefrom
filipecosta90:redisbenchmark.resp3

Conversation

@filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Feb 23, 2022 •
edited by oranagra
Loading

Adds -3 option to cause redis-benchmark to send a HELLO 3 to it can benchmark the effects of RESP3 on the server.

oranagra
oranagra reviewed Feb 23, 2022
View reviewed changes
@filipecosta90 filipecosta90 mentioned this pull request Feb 23, 2022
Merged
@oranagra
Copy link
Member

oranagra commented Feb 23, 2022

@yossigo please ack (i suppose despite being an interface change, it's not a major decision)

@oranagra
Copy link
Member

oranagra commented Feb 23, 2022

p.s. should me mention this in the release notes?

@yossigo yossigo added the release-notes indication that this issue needs to be mentioned in the release notes label Feb 27, 2022
@yossigo
Copy link
Collaborator

yossigo commented Feb 27, 2022

@oranagra I agree it's not a major decision, but should be in the release notes.

@oranagra oranagra merged commit 9f30dd0 into redis:unstable Feb 27, 2022
@oranagra oranagra mentioned this pull request Feb 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yossigo yossigo yossigo approved these changes

@oranagra oranagra oranagra approved these changes

Assignees

No one assigned

Labels

release-notes indication that this issue needs to be mentioned in the release notes

Projects

Redis 7.0
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@filipecosta90 @oranagra @yossigo