Remove ALLOW_BUSY from REPLICAOF and add it to REPLCONF. Add DEPRECATED doc flag to SLAVEOF, mark it as deprecated.#10315
Merged
oranagra merged 2 commits intoredis:unstablefrom Feb 22, 2022
Conversation
enjoy-binbin
added
the
state:to-be-merged
Contributor
Author
|
it does share the same logic in ths past, we use |
oranagra
reviewed
Feb 20, 2022
enjoy-binbin
force-pushed
the
fixes_in_slaveof_json
branch
from
7f849c5 to
6a1d3ad
Compare
enjoy-binbin
changed the title
oranagra
approved these changes
Feb 21, 2022
enjoy-binbin
changed the title
DEPRECATED doc flag to SLAVEOF, mark it as deprecated.
enjoy-binbin
changed the title
DEPRECATED doc flag to SLAVEOF, mark it as deprecated.
oranagra
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9963 we added the
ALLOW_BUSYflag to REPLICAOF command.This flag should have been applied to REPLCONF not REPLICAOF.
Add
DEPRECATEDdoc flag to SLAVEOF, mark it as deprecated.While the s-word isn't going away soon, the actual command has
an alternative (REPLICAOF) and we should direct people to use it.