Add bus_port argument in cluster-meet.json#10304
Merged
oranagra merged 2 commits intoredis:unstablefrom Jun 23, 2022
Merged
Conversation
enjoy-binbin
force-pushed
the
cluster_meet_cport
branch
from
7de12c0 to
ae72d7d
Compare
In `CLUSTER MEET`, bus-port argument was added in 11436b1. For cluster announce ip / port implementation, part of the 4.0-RC1. And in redis#9389, we add a new cluster-port config and make cluster bus port configurable, part of the 7.0-RC1.
enjoy-binbin
force-pushed
the
cluster_meet_cport
branch
from
ae72d7d to
2aaf996
Compare
enjoy-binbin
changed the title
enjoy-binbin
added
the
state:to-be-merged
zuiderkwast
approved these changes
Mar 28, 2022
oranagra
approved these changes
Jun 23, 2022
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
In `CLUSTER MEET`, bus-port argument was added in 11436b1. For cluster announce ip / port implementation, part of the 4.0-RC1. And in redis#9389, we add a new cluster-port config and make cluster bus port configurable, part of the 7.0-RC1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that the
bus-portparameter is listed in cluster help, but not documented in redis-docredis/src/cluster.c
Lines 5022 to 5023 in 3881f78
In
CLUSTER MEET, bus-port argument was added in 11436b1.For cluster announce ip / port implementation, part of the
4.0-RC1.
And in #9389, we add a new cluster-port config and make
cluster bus port configurable, part of the 7.0-RC1.