Fix RM_SetModuleOptions flag collision#10284
Merged
oranagra merged 2 commits intoredis:unstablefrom Feb 11, 2022
Merged
Conversation
sundb
changed the title
oranagra
reviewed
Feb 11, 2022
oranagra
approved these changes
Feb 11, 2022
oranagra
added
the
release-notes
oranagra
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug is introduced by #9323. (released in 7.0 RC1)
The define of
REDISMODULE_OPTIONS_HANDLE_IO_ERRORSandREDISMODULE_OPTION_NO_IMPLICIT_SIGNAL_MODIFIEDhave the same value.This will result in skipping
signalModifiedKey()afterRM_CloseKey()if the module has setREDISMODULE_OPTIONS_HANDLE_REPL_ASYNC_LOADoption.The implication is missing WATCH and client side tracking invalidations.
Other changes:
no-implicit-signal-modifiedto the options in INFO modules