Fix SENTINEL SET config rewrite test#10232
Merged
oranagra merged 1 commit intoredis:unstablefrom Feb 4, 2022
Merged
Conversation
Change the sentinel config file to a directory in SENTINEL SET test. So it will now fail on the `rename` in `rewriteConfigOverwriteFile`. The test used to set the sentinel config file permissions to `000` to simulate failure. But it fails on centos7 / freebsd / alpine. (introduced in redis#10151) Other changes: 1. More error messages after the config rewrite failure. 2. Modify arg name `force_all` in `rewriteConfig` to `force_write`. (was rename in redis#9304) 3. Fix a typo in debug quicklist-packed-threshold, then -> than. (redis#9357)
Contributor
Author
oranagra
approved these changes
Feb 4, 2022
enjoy-binbin
added
the
state:to-be-merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the sentinel config file to a directory in SENTINEL SET test.
So it will now fail on the
renameinrewriteConfigOverwriteFile.The test used to set the sentinel config file permissions to
000tosimulate failure. But it fails on centos7 / freebsd / alpine. (introduced in #10151)
Other changes:
force_allinrewriteConfigtoforce_write. (was rename in Add debug config flag to print certain config values on engine crash #9304)